Cache #124
Merged
Cache #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
commented
Sep 21, 2019
| @@ -74,6 +79,7 @@ public struct Config: Codable { | |||
| viewAsDeviceRule = try container.decodeIfPresent(Optional<ViewAsDeviceConfig>.self, forKey: .viewAsDeviceRule) ?? nil | |||
| reporter = try container.decodeIfPresent(String.self, forKey: .reporter) ?? "xcode" | |||
| disableWhileBuildingForIB = try container.decodeIfPresent(Bool.self, forKey: .disableWhileBuildingForIB) ?? true | |||
| ignoreCache = try container.decodeIfPresent(Bool.self, forKey: .ignoreCache) ?? false | |||
There was a problem hiding this comment.
What do you think about default value? Should we enable cache by default?
There was a problem hiding this comment.
Yes enabled by default is the good choice if there is no way to forgot some issues
phimage
reviewed
Sep 23, 2019
|
@phimage Your understanding is almost correct. As you said, we should re-check if IBLinter version changed.
If the top two are changed, IBLinter ignore existing cache files and re-check all files again. |
phimage
approved these changes
Sep 23, 2019
|
@phimage Thank you for reviewing 🦄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBLinter checks whole files every time but there are many unnecessary processes when most of them are not changed.
This PR adds lint cache for each IB file.
In my project, IBLinter took 7 sec every time but this change reduced it to 2 sec when there is cache.