Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule duplicate_id, which detect xml element duplicate id #126

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

phimage
Copy link
Member

@phimage phimage commented Oct 30, 2019

Browse the element tree and index on id to find duplicates

Could occurs after fixing git conflict ie. you keep tow times the same line, or maybe if you do some manual edit of storyboard

I do not display duplicates elements like DuplicateConstraintsRules, only the id
I compute the list by id but description of element could be not very readable

Copy link
Collaborator

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to name duplicateIDRule

Sources/IBLinterKit/Rules/DuplicateIdRule.swift Outdated Show resolved Hide resolved
Rules.md Outdated Show resolved Hide resolved
Sources/IBLinterKit/Rules/DuplicateIdRule.swift Outdated Show resolved Hide resolved
Tests/IBLinterKitTest/Rules/DuplicateIdRuleTests.swift Outdated Show resolved Hide resolved
@phimage
Copy link
Member Author

phimage commented Nov 20, 2019

I have made the requested change, but github CI do not launch workflow actions on new commits
I made one branch in my fork to launch the test https://github.com/phimage/IBLinter/runs/311332176 and it work
So I will merge

@phimage phimage merged commit cbc12e9 into IBDecodable:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants