Add reuse_identifier rule and test. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phimage
reviewed
Jan 20, 2020
| // Currently only supported TableViewCell and CollectionViewCell (contains UICollectionReusableView) | ||
| if let tableView = view as? TableView { | ||
| return tableView.prototypeCells?.compactMap { | ||
| guard let customClass = $0.customClass, let reuseIdentifier = $0.reuseIdentifier else { |
There was a problem hiding this comment.
there is a IBReusable protocol implemented by the two type of cells
maybe it could help to factorise some code
So you can extract a function or append list of cells into one before using compactMap
Or we could also add a protocol on TableView and CollectionView to provide the reusableCells of type IBReusable, so only one if let parentResuable = view as? IBReusableParentView { is necessary
There was a problem hiding this comment.
@phimage Thanks for your feedback. I'll try that pattern to aggregate logic :)
There was a problem hiding this comment.
by the way, that view types are defined in IBDecodable. Should I modify that project first or add extension it from IBLinter project?
There was a problem hiding this comment.
ok, firstly I try to append list of cell pattern without modify IBDecodable project.
r-plus
changed the title
|
@kateinoigakukun @phimage okey, i finish up implementation for NOTE: I added some mess commits for this PR, so please squash merge to clean up git history when you merge or I'll rebase before or after review if you want. looks like CI is not running, this is test result in my local. `swift test` result |
phimage
reviewed
Jan 21, 2020
| } else if let collectionView = view as? CollectionView, let cells = collectionView.cells { | ||
| reusableCells += cells | ||
| } else if let cell = view as? IBReusable & ViewProtocol { | ||
| reusableCells += [cell] |
There was a problem hiding this comment.
very special case :)
ok because cells are not in TableView or CollectionView subviews it seems
There was a problem hiding this comment.
I estimate this else if case is for XIB that defined TableViewCell or CollectionVIewCell without parent of TableView and CollectionView.
That type of xib is added as test resource.
phimage
requested changes
Jan 21, 2020
Rules.md
Outdated
| | Default Rule | `false` | | ||
|
|
||
| Check that Reuse Identifier same as view class name. | ||
| Currently only supported TableViewCell and CollectionViewCell. |
There was a problem hiding this comment.
back-ticks on TableViewCell and CollectionViewCell
phimage
approved these changes
Jan 21, 2020
| | Default Rule | `false` | | ||
|
|
||
| Check that Reuse Identifier same as view class name. | ||
| Currently only supported `TableViewCell` and `CollectionViewCell`. |
There was a problem hiding this comment.
Sorry for confusion. This file is generated automatically based on Rule protocol information. Could you add second line description to ReuseIdentifierRule.description ?
kateinoigakukun
approved these changes
Jan 22, 2020
r-plus
commented
Jan 22, 2020
|
|
||
| static let identifier = "reuse_identifier" | ||
| static let description = """ | ||
| Check that ReuseIdentifier same as class name.\\ |
There was a problem hiding this comment.
trailing two space to line break for markdown is not good i think because Xcode have Automatically trim trailing whitespace option that trim space for line break.
So i choose back-tick style line break for markdown.
|
Great thanks! LGTM |
|
thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I just try to implement
reuse_identifierrule, how about this rule?If acceptable, I'll continue to add xib support and docs for it.
Closes #136