image_resources rule support custom symbol image #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-plus
changed the title
r-plus
force-pushed
the
feature/image_resources/support_custom_symbol
branch
from
e0ad69f to
d1f7b5f
Compare
|
thx for merge #141, rebased from latest master branch. |
phimage
approved these changes
Feb 3, 2020
|
Ok for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 11 support custom symbol image (SVG).
This PR add support it for
image_resourcesrule to correctly detect of custom symbol image.NOTE
This PR is substantially one commit d8e1d59, based onentryValues(for:)method by #141#141 is merged, I rebased.