Add a new rule: HidesBottomBar #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I've just released IBDecodable 0.5.0 including your change. |
|
@kateinoigakukun thanks again! |
| } | ||
|
|
||
| private func validate<T: InterfaceBuilderFile>(for viewController: ViewControllerProtocol, file: T) -> Violation? { | ||
| guard let customClass = viewController.customClass, |
There was a problem hiding this comment.
It seems this rule is only applied for view controllers with custom classes, is this intentional? Should we warn a VC, which doesn't specify hidesBottomBarWhenPushed and doesn't have a custom class?
|
@kateinoigakukun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Add a new rule to check if HidesBottomBarWhenPushed is enabled
HidesBottomBar rule is especially useful when the most of ViewControllers in your app need to be pushed with their bottom bar hidden.
falseby default, I assume this rule can help prevent possible human errors.In order to implement the rule, I had to make change to IBDecodable, too.
Packages.swiftand open this PR, once the one for IBDecodable's approvedP.S.
Thanks for this wonderful tool!