UI-14859: Instance Group Delete Bugfix #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepaksibm
reviewed
Apr 29, 2021
ibm/resource_ibm_is_lb.go
Outdated
| @@ -985,7 +985,7 @@ func isWaitForLBAvailable(sess *vpcv1.VpcV1, lbId string, timeout time.Duration) | |||
| log.Printf("Waiting for load balancer (%s) to be available.", lbId) | |||
|
|
|||
| stateConf := &resource.StateChangeConf{ | |||
| Pending: []string{"retry", isLBProvisioning}, | |||
| Pending: []string{"retry", isLBProvisioning, "update_pending", "delete_pending"}, | |||
There was a problem hiding this comment.
Update_pending states are not needed , as the refresh function returns "provisioning" for all other states except for 'active' and 'failed'
There was a problem hiding this comment.
Hi @deepaksibm I am using the load_balancer's resource function. So I can't remove anything from there because it is used for load_balancer creation as well.
There was a problem hiding this comment.
why delete_pending is addeed for active status
There was a problem hiding this comment.
@hkantare Added just like that..Should I remove it??
mayukh-sarkar-1
changed the title
hkantare
reviewed
May 3, 2021
ibm/resource_ibm_is_lb.go
Outdated
| @@ -985,7 +985,7 @@ func isWaitForLBAvailable(sess *vpcv1.VpcV1, lbId string, timeout time.Duration) | |||
| log.Printf("Waiting for load balancer (%s) to be available.", lbId) | |||
|
|
|||
| stateConf := &resource.StateChangeConf{ | |||
| Pending: []string{"retry", isLBProvisioning}, | |||
| Pending: []string{"retry", isLBProvisioning, "update_pending", "delete_pending"}, | |||
There was a problem hiding this comment.
why delete_pending is addeed for active status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was while deleting the instance_groups, we need to check if the load balancer is active or not. If not, then wait for the load balancer to be active and then delete the instance groups. Otherwise raise the error.
Jira Task: https://jiracloud.swg.usma.ibm.com:8443/browse/UI-14859
Bug Description
Destroy fails with