Add new API param to provider #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
May 12, 2021
| @@ -117,7 +123,6 @@ func dataSourceIbmIamAccountSettingsRead(context context.Context, d *schema.Reso | |||
| } | |||
|
|
|||
| getAccountSettingsOptions := &iamidentityv1.GetAccountSettingsOptions{} | |||
| //getAccountSettingsOptions.SetIncludeHistory(d.Get("include_history").(bool)) | |||
There was a problem hiding this comment.
Why include_history is removed from option struct...we have it has a optioanl argument
There was a problem hiding this comment.
This was commented out originally, but I have re-added it now and included it in the list of args in the md file.
| @@ -47,3 +47,4 @@ In addition to all arguments above, the following attributes are exported: | |||
|
|
|||
| * `session_invalidation_in_seconds` - Defines the period of time in seconds in which a session will be invalidated due to inactivity. Valid values: * Any whole number between '900' and '7200' * NOT_SET - To unset account setting and use service default. | |||
|
|
|||
| * `max_sessions_per_identity` - Defines the max allowed sessions per identity required by the account. Value values: * Any whole number greater than '0' * NOT_SET - To unset account setting and use service default | |||
There was a problem hiding this comment.
This description of what values should go into resource doc...datasource we just set back the value which we get from API
There was a problem hiding this comment.
Thanks, I've moved these to the resource doc.
Daniel-Byrne
force-pushed
the
iam-iden-max-sessions
branch
from
9ac9ad7 to
6ecc00e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update provider to include a new parameter
max_sessions_per_identityin the Account Settings APIRelevant tests are passing.
