Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dbaas example #2649

Closed
wants to merge 4 commits into from
Closed

add dbaas example #2649

wants to merge 4 commits into from

Conversation

PanLiyuan
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@@ -35,6 +35,33 @@ resource "ibm_resource_instance" "resource_instance" {
}
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a title for this section in Bold something
Provisioning a Hyper Protect DBaaS PostgreSQL Service...
something like this example
https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/website/docs/r/iam_access_group_policy.html.markdown#access-group-policy-for-all-identity-and-access-enabled-services

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkantare I added a title. Please review.

@hkantare
Copy link
Collaborator

Detect secrets failed can you please validate and add false positive secrets

@PanLiyuan
Copy link
Author

@hkantare I don't understand. Could you explain how I should do this?

@hkantare
Copy link
Collaborator

parameters = {
    "name": "cluster01",
    "admin_name": "admin",
    "password": "Hyperprotectdbaas0001"
    "confirm_password": "Hyperprotectdbaas0001",
    "db_version": "10"
  }

From this section of code the detect_secret tool is detecting mostly the password as secret ..
https://w3.ibm.com/w3publisher/detect-secrets/developer-tool
Install the detect secret tool
detect-secrets scan --update .secrets.baseline
detect-secrets audit .secrets.baseline (to mark it as false positive)
push the updated secret base line also

@PanLiyuan
Copy link
Author

@hkantare thanks a lot for your help, but I couldn't install Homebrew because of connection issues. I tried many times (maybe it's because I'm working from home). Is there any workaround for this secret problem?

@hkantare
Copy link
Collaborator

I raised a PR to your brach by updating detect secret ...
PanLiyuan#1

Can you merge this so that it will update this pr with required file

@PanLiyuan
Copy link
Author

@hkantare thank you for your help! I merged that PR.

@hkantare
Copy link
Collaborator

There are still some conflicts ...so I raised a PR from my end
#2683
Can you check this so that we can merge this pr and close this pr

@hkantare
Copy link
Collaborator

closing this PR

@hkantare hkantare closed this May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants