Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: added support for identifier in is_image datasource #3012

Merged
merged 1 commit into from
Sep 2, 2021
Merged

feature: added support for identifier in is_image datasource #3012

merged 1 commit into from
Sep 2, 2021

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Aug 19, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #3009

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@uibm uibm changed the title bug: added support for identifier in is_image datasource feature: added support for identifier in is_image datasource Aug 20, 2021
astha-jain
astha-jain approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@hkantare hkantare merged commit 93f02c1 into IBM-Cloud:master Sep 2, 2021
@uibm uibm deleted the bug-imageid-datasource branch October 12, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astha-jain astha-jain astha-jain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uibm @astha-jain @hkantare