Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(Cloud Databases): add support for User types, roles #3475

Merged
merged 1 commit into from
May 13, 2022

Conversation

alexhemard
Copy link
Collaborator

@alexhemard alexhemard commented Jan 4, 2022

Adds support for multiple user types (database, ops_manager, read_only_replica) for the IBM Database Resource
See https://cloud.ibm.com/apidocs/cloud-databases-api/cloud-databases-api-v5#createdatabaseuser

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMMongoDBEnterprise'
...
--- PASS: TestAccIBMMongoDBEnterpriseDatabaseInstanceGroupBasic (5207.81s)
--- PASS: TestAccIBMMongoDBEnterpriseDatabaseInstanceBasic (27551.47s)
...
$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstance'
...
--- PASS: TestAccIBMDatabaseInstanceElasticsearchImport (465.51s)
--- PASS: TestAccIBMDatabaseInstanceEtcdImport (870.41s)
--- PASS: TestAccIBMDatabaseInstanceMongodbBasic (1534.00s)
--- PASS: TestAccIBMDatabaseInstanceMongodbImport (1152.09s)
--- PASS: TestAccIBMDatabaseInstancePostgresBasic (2373.14s)
--- PASS: TestAccIBMDatabaseInstancePostgresGroup (2593.68s)
--- PASS: TestAccIBMDatabaseInstancePostgresImport (944.31s)
--- PASS: TestAccIBMDatabaseInstancePostgresNode (2270.03s)
--- PASS: TestAccIBMDatabaseInstanceRabbitmqImport (809.02s)
--- PASS: TestAccIBMDatabaseInstanceRedisImport (661.52s)
--- PASS: TestAccIBMDatabaseInstance_Cassandra_Group (6637.37s)
--- PASS: TestAccIBMDatabaseInstance_Cassandra_Node (4408.87s)
--- PASS: TestAccIBMDatabaseInstance_Elasticsearch_Basic (854.69s)
--- PASS: TestAccIBMDatabaseInstance_Elasticsearch_Group (1522.81s)
--- PASS: TestAccIBMDatabaseInstance_Elasticsearch_Node (789.75s)
--- PASS: TestAccIBMDatabaseInstance_Etcd_Basic (873.66s)
--- PASS: TestAccIBMDatabaseInstance_Rabbitmq_Basic (1422.83s)
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (705.72s)
...

@alexhemard alexhemard force-pushed the cdb-v5-users branch 2 times, most recently from bde1076 to e90f0de Compare January 6, 2022 05:19
@hkantare
Copy link
Collaborator

hkantare commented Jan 7, 2022

The doc for database datasource is not updated website/docs/d/database.html.markdown

Please share the testresults of all the testcases...

ibm/config.go Outdated Show resolved Hide resolved
ibm/data_source_ibm_database.go Outdated Show resolved Hide resolved
ibm/resource_ibm_database.go Outdated Show resolved Hide resolved
ibm/resource_ibm_database.go Outdated Show resolved Hide resolved
website/docs/r/database.html.markdown Outdated Show resolved Hide resolved
@alexhemard alexhemard changed the title WIP - Add IBM Cloud Databases V5 Users API support Cloud Databases V5 Users API support Jan 13, 2022
@alexhemard
Copy link
Collaborator Author

The doc for database datasource is not updated website/docs/d/database.html.markdown

Removed the changes to the ibm_database data source but updated the documentation since it currently seems to imply it will create a Read-only replica

@hkantare
Copy link
Collaborator

hkantare commented Feb 1, 2022

Can you reabse the PR with respective to new folder structure

@alexhemard alexhemard force-pushed the cdb-v5-users branch 2 times, most recently from 77b16c0 to a641e70 Compare March 23, 2022 18:23
@alexhemard alexhemard force-pushed the cdb-v5-users branch 2 times, most recently from 9c5aa7c to 627bede Compare April 7, 2022 15:54
@alexhemard alexhemard force-pushed the cdb-v5-users branch 2 times, most recently from 287a51b to 7e68f7e Compare April 26, 2022 15:37
@alexhemard alexhemard changed the title Cloud Databases V5 Users API support enhancement(Cloud Databases): add support for User types, roles Apr 28, 2022
@obai-1
Copy link
Collaborator

obai-1 commented May 12, 2022

@hkantare since all the comments on this PR are addressed, I will go ahead and merge it. Pls let me know any objections.

@obai-1 obai-1 merged commit e271bda into IBM-Cloud:master May 13, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants