Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add critical as a pending cluster state #4225

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

z0za
Copy link
Contributor

@z0za z0za commented Dec 7, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4214

Output from acceptance testing:

% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterEnvvar'
...
=== RUN   TestAccIBMContainerVpcClusterEnvvar
--- PASS: TestAccIBMContainerVpcClusterEnvvar (1493.94s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1495.348s

% make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainer_ClusterConfigDataSourceVpcBasic'
...
=== RUN   TestAccIBMContainer_ClusterConfigDataSourceVpcBasic
--- PASS: TestAccIBMContainer_ClusterConfigDataSourceVpcBasic (1787.98s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1789.338s

...

@z0za z0za marked this pull request as ready for review December 9, 2022 10:02
@z0za z0za force-pushed the handle_critical_state branch from 98f0a34 to 57d4c2b Compare December 12, 2022 07:54
@hkantare hkantare merged commit ab9543f into IBM-Cloud:master Dec 15, 2022
@z0za z0za deleted the handle_critical_state branch December 15, 2022 09:56
@ocofaigh
Copy link
Contributor

ocofaigh commented Jan 4, 2023

It seems this did not fully fix the issue. See #4266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ibm_container_vpc_cluster ] wait_till = "Normal" does not work
3 participants