add ForceNew tag to OS fields #4279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkantare
reviewed
Jan 17, 2023
| @@ -214,7 +214,7 @@ Review the argument references that you can specify for your resource. | |||
| - `machine_type` - (Optional, Forces new resource, String) The machine type for your worker node. The machine type determines the amount of memory, CPU, and disk space that is available to the worker node. For an overview of supported machine types, see [Planning your worker node setup](https://cloud.ibm.com/docs/containers?topic=containers-planning_worker_nodes). You can retrieve the value by executing the `ibmcloud ks machine-types <data-center>` command in the IBM Cloud CLI. | |||
| - `name` - (Required, Forces new resource, String) The name of the cluster. The name must start with a letter, can contain letters, numbers, and hyphen (-), and must be 35 characters or fewer. Use a name that is unique across regions. The cluster name and the region in which the cluster is deployed form the fully qualified domain name for the Ingress subdomain. To ensure that the Ingress subdomain is unique within a region, the cluster name might be truncated and appended with a random value within the Ingress domain name. | |||
| - `no_subnet` - (Optional, Forces new resource, Bool) If set to **true**, no portable subnet is created during cluster creation. The portable subnet is used to provide portable IP addresses for the Ingress subdomain and Kubernetes load balancer services. If set to **false**, a portable subnet is created by default. The default is **false**. | |||
| - `operating_system` - (Optional, String) The operating system of the workers in the default worker pool. For supported options, see [Red Hat OpenShift on IBM Cloud CLI reference](https://cloud.ibm.com/docs/openshift?topic=openshift-kubernetes-service-cli&interface=ui#cluster). | |||
| - `operating_system` - (Optional, String) The operating system of the workers in the default worker pool. For supported options, see [Red Hat OpenShift on IBM Cloud version information](https://cloud.ibm.com/docs/openshift?topic=openshift-openshift_versions) or [IBM Cloud Kubernetes Service version information](https://cloud.ibm.com/docs/containers?topic=containers-cs_versions). | |||
There was a problem hiding this comment.
Can be add "Forces new resource" in all docs
(Optional, Forces new resource, String)
| @@ -186,7 +186,7 @@ Review the argument references that you can specify for your resource. | |||
| - `instance_id` - (Optional, String) The GUID of the Key Protect instance. | |||
| - `private_endpoint` - (Optional, Bool) Set **true** to configure the KMS private service endpoint. Default value is **false**. | |||
| - `kube_version` - (Optional, String) Specify the Kubernetes version, including the major.minor version. If you do not include this flag, the default version is used. To see available versions, run `ibmcloud ks versions`. | |||
| - `operating_system` - (Optional, String) The operating system of the workers in the default worker pool. For supported options, see [Red Hat OpenShift on IBM Cloud CLI reference](https://cloud.ibm.com/docs/openshift?topic=openshift-kubernetes-service-cli&interface=ui#cluster). | |||
| - `operating_system` - (Optional, String) The operating system of the workers in the default worker pool. For supported options, see [Red Hat OpenShift on IBM Cloud version information](https://cloud.ibm.com/docs/openshift?topic=openshift-openshift_versions) or [IBM Cloud Kubernetes Service version information](https://cloud.ibm.com/docs/containers?topic=containers-cs_versions). | |||
z0za
force-pushed
the
mark_os_forcenew
branch
from
fc2451e to
d9b9f04
Compare
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Feb 1, 2023
* add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <[email protected]>
adya1303
pushed a commit
to adya1303/terraform-provider-ibm
that referenced
this pull request
Feb 2, 2023
* add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <[email protected]>
hkantare
added a commit
that referenced
this pull request
Feb 7, 2023
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <[email protected]> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <[email protected]> * add ForceNew tag to OS fields (#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <[email protected]> * warning state in pending list, WARN logs about warning and critical s… (#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix #4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <[email protected]> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client --------- Signed-off-by: Brian Gleeson <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: ElliotG <[email protected]> Co-authored-by: Brian Gleeson <[email protected]> Co-authored-by: Zoltán Illés <[email protected]> Co-authored-by: Zoltan Illes <[email protected]> Co-authored-by: attilatabori <[email protected]> Co-authored-by: gmarjoram <[email protected]> Co-authored-by: Deepak Selvakumar <[email protected]> Co-authored-by: hkavya26 <[email protected]> Co-authored-by: Ujjwal Kumar <[email protected]> Co-authored-by: hkantare <[email protected]> Co-authored-by: alex hemard <[email protected]> Co-authored-by: Ben Buchanan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <[email protected]> Co-authored-by: Sandeep S <[email protected]> Co-authored-by: Bhavesh Shrivastav <[email protected]> Co-authored-by: Carl Petersson <[email protected]>
hkantare
added a commit
that referenced
this pull request
Jun 15, 2023
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <[email protected]> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <[email protected]> * add ForceNew tag to OS fields (#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <[email protected]> * warning state in pending list, WARN logs about warning and critical s… (#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix #4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <[email protected]> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client * Adopted new API changes * updated .secrets.baseline * fix formating provider.go * Corrected the testing target CRN * Modified the input table of content in README * Added more examples * minor changes in service names * Picking mr gosdk from master * Added info on settings id * fixing issues * Fix removal of permitted_target_regions * Fix crashing issue due to empty targets * Added info on first time setting of primary_metadata_region * Added changes as per comments --------- Signed-off-by: Brian Gleeson <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: ElliotG <[email protected]> Co-authored-by: Brian Gleeson <[email protected]> Co-authored-by: Zoltán Illés <[email protected]> Co-authored-by: Zoltan Illes <[email protected]> Co-authored-by: attilatabori <[email protected]> Co-authored-by: gmarjoram <[email protected]> Co-authored-by: Deepak Selvakumar <[email protected]> Co-authored-by: hkavya26 <[email protected]> Co-authored-by: Ujjwal Kumar <[email protected]> Co-authored-by: hkantare <[email protected]> Co-authored-by: alex hemard <[email protected]> Co-authored-by: Ben Buchanan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <[email protected]> Co-authored-by: Sandeep S <[email protected]> Co-authored-by: Bhavesh Shrivastav <[email protected]> Co-authored-by: Carl Petersson <[email protected]>
omaraibrahim
pushed a commit
to omaraibrahim/terraform-provider-ibm
that referenced
this pull request
Jul 20, 2023
* Added new service Metrics Router to repo * Updated secret baseline file * Updated baseline file with is_secret * Changed sdk repo path * Fixed a couple typos Found a couple typos when I was deploying a cluster. This should fix it. * Updates to tekton-pipeline support (IBM-Cloud#4235) * fix(tekton): pos-GA updates * chore(tekton): update Go SDK version * fix(tekton): finalise tekton updates Signed-off-by: Brian Gleeson <[email protected]> * fix(tekton): Address Worker and href feedback Signed-off-by: Brian Gleeson <[email protected]> * add ForceNew tag to OS fields (IBM-Cloud#4279) * add ForceNew tag to OS fileds, updated doc * add forces new resource tag to the doc Co-authored-by: Zoltan Illes <[email protected]> * warning state in pending list, WARN logs about warning and critical s… (IBM-Cloud#4283) * warning state in pending list, WARN logs about warning and critical states * added extra clarification in docs about wait_till Normal option * Continuous Delivery - Git PAT support (IBM-Cloud#4276) * Git PAT support * Fix example * vpc address prefix and subnet doc fix * Fix IBM-Cloud#4132: fix values_metadata argument in schematics resource * enhancement(vpc-go-sdk) : Migration to latest 0.30.0 * fix(networkacl) : made name optional to allow create_before_destroy * Remove certificate manager service support * Fix ibm_appid_cloud_directory_user missing userName * update provider metadata * update CHANGELOG * Bump up version to 1.50.0-beta0 * add optional secondary storage fields to IKS cluster and workerpool (IBM-Cloud#4255) * add user defined secondary storage support to vpc cluster and workerpool * tc fix for non secondarystorage case * update docs and descriptions * remove userdefined string, count and size is now integer in secondarystorage schema * update docs Co-authored-by: Zoltan Illes <[email protected]> * CD: Field description updates for PAT * refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk (IBM-Cloud#4218) * fix: documentation fix for ibm_cm_object resource * dependabot: bump github/issue-labeler from 2.5 to 2.6 Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6. - [Release notes](https://github.com/github/issue-labeler/releases) - [Commits](github/issue-labeler@v2.5...v2.6) --- updated-dependencies: - dependency-name: github/issue-labeler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * chore(tekton): bump Tekton Go SDK version * dependabot: bump actions/checkout from 3.2.0 to 3.3.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.2.0...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * update tags from globaltags to search API * update metadata * update CHANGELOG * Bump up version to 1.50.0 * Adding new destination , integration and updating subscription resources for event notifications (IBM-Cloud#4321) * adding new destination, updating email subscription and integrayion resources for event notification service * Update go.mod updating event notification package * Update go.sum updating event-notifications entry in go.sum * Deprecate: retain schema and remove code * Remove deprecated resource notification for VPC route resource (IBM-Cloud#4323) * removal notification for vpc route * updated the release number: v1.51.0 - removal notification v1.52.0 - resource is removed * Single node infrastructure added (IBM-Cloud#4269) * Single node infrastructure added * Variable fix * single-node code added * Empty-Commit to run tests with updated sdk. * Updated sdk version * Added code for data recource * Added documentation * Added documentation * Corrected typo * Added test case for new variable * Removed single-node resource. Added single-node parameters to existing create cluster resource. * Changes reflecting PR comments. * Added test case for single node clusters. Updated variables. * Updated version * fix: allow data to be set/updated when already unquoted * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (IBM-Cloud#4234) * refactor(Cloud Databases): configuration uses cloud-databases-go-sdk * address PR comments * remove unused bluemix client * Adopted new API changes * updated .secrets.baseline * fix formating provider.go * Corrected the testing target CRN * Modified the input table of content in README * Added more examples * minor changes in service names * Picking mr gosdk from master * Added info on settings id * fixing issues * Fix removal of permitted_target_regions * Fix crashing issue due to empty targets * Added info on first time setting of primary_metadata_region * Added changes as per comments --------- Signed-off-by: Brian Gleeson <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: ElliotG <[email protected]> Co-authored-by: Brian Gleeson <[email protected]> Co-authored-by: Zoltán Illés <[email protected]> Co-authored-by: Zoltan Illes <[email protected]> Co-authored-by: attilatabori <[email protected]> Co-authored-by: gmarjoram <[email protected]> Co-authored-by: Deepak Selvakumar <[email protected]> Co-authored-by: hkavya26 <[email protected]> Co-authored-by: Ujjwal Kumar <[email protected]> Co-authored-by: hkantare <[email protected]> Co-authored-by: alex hemard <[email protected]> Co-authored-by: Ben Buchanan <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Divya-Singh1693 <[email protected]> Co-authored-by: Sandeep S <[email protected]> Co-authored-by: Bhavesh Shrivastav <[email protected]> Co-authored-by: Carl Petersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Output from acceptance testing: