Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added wait logic for tags async #5174

Merged
merged 2 commits into from
Mar 25, 2024
Merged

added wait logic for tags async #5174

merged 2 commits into from
Mar 25, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Mar 6, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISSubnet_basic
=== RUN   TestAccIBMISSubnet_basic
--- PASS: TestAccIBMISSubnet_basic (265.94s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     267.902s

--- PASS: TestAccIBMISVPC_basic_apm (121.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     515.840s

@sreekarbvibm
Copy link
Contributor

LGTM

@uibm uibm marked this pull request as ready for review March 21, 2024 15:57
@uibm uibm force-pushed the tagging-async-issue branch from 74009e2 to 7d97a67 Compare March 22, 2024 12:38
hkantare
hkantare reviewed Mar 24, 2024
View reviewed changes
ibm/flex/structures.go Outdated
@@ -2558,11 +2559,44 @@ func UpdateGlobalTagsUsingCRN(oldList, newList interface{}, meta interface{}, re
if err != nil {
return fmt.Errorf("[ERROR] Error updating database tags %v : %s\n%s", add, err, resp)
}
response, errored := waitForTagsAvailable(meta, resourceID, resourceType, tagType, news, 1*time.Minute)
if errored != nil {
log.Printf(`[ERROR] Error waiting for tags database tags %s : %v
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

database tags means?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to resource tags. Database tags is tags on remote

@uibm uibm requested a review from hkantare March 25, 2024 05:11
@hkantare hkantare merged commit 705162f into IBM-Cloud:master Mar 25, 2024
1 check passed
@uibm uibm deleted the tagging-async-issue branch March 25, 2024 13:30
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@uibm @ismirlia
added wait logic for tags async (IBM-Cloud#5174)
23b4122 
* added wait logic for tags async

* updated error log as per review comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uibm @sreekarbvibm @hkantare