-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deleting instances with replicant attribute set #5176
Merged
+104
−38
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c9a8f86
Fix replicant vms not being deleted
ismirlia cea3934
Update documentation
ismirlia 0f81cc1
Use flex function instead of strings
ismirlia cf2cd9e
Change placement group to be a computed value
ismirlia 73a8ae0
Update resource instance tests
ismirlia 6bf81db
Add replicant instance test
ismirlia 573411e
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia acf893b
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia 587118d
Fix compilation error
ismirlia ea78853
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia 5121dce
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia f42e326
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia 5e69a36
Separate command from checking
ismirlia 5e717ae
Merge branch 'master' of github.com:powervs-ibm/terraform-provider-ib…
ismirlia 1073c7b
Add replicant warning
ismirlia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If instead of delete-wait and loop again, can we have two loops? One loop will delete all the instances and the other loop will check the deletion status. This will save lots of time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes.