-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KP: Adding attribute registrations for resource instance key and attribute endpoint_type for key policies #5221
Merged
hkantare
merged 3 commits into
IBM-Cloud:master
from
tyao117:kms-private-registration-add
Mar 24, 2024
Merged
KP: Adding attribute registrations for resource instance key and attribute endpoint_type for key policies #5221
hkantare
merged 3 commits into
IBM-Cloud:master
from
tyao117:kms-private-registration-add
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for instance policy endpoint type
|
tyao117
changed the title
feat: Adding attribute registrations for resource instance key and attribute endpoint_type for key policies
KP: Adding attribute registrations for resource instance key and attribute endpoint_type for key policies
Mar 20, 2024
Can you update documentaion for "registrations" in docs website/docs/r folder |
@hkantare added. |
ismirlia
pushed a commit
to powervs-ibm/terraform-provider-ibm
that referenced
this pull request
Apr 11, 2024
…ibute endpoint_type for key policies (IBM-Cloud#5221) * feat: Adding registrations for the instance key and endpoint_type * adding the logging for registration * adding documentation --------- Co-authored-by: Timothy-Yao <[email protected]>
Unit tests weren't run for kms. This has caused tests to panic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
terraform-ibm-modules/terraform-ibm-landing-zone#738
Closes #5154
Output from acceptance testing: