Support outbound-traffic-protection

[golibali]

A new API endpoint was introduced /network/v2/outbound-traffic-protection, so from now the outbound-traffic-protection can be modified after cluster creation as well. This PR is to support this scenario. Only works with Secure-by-default clusters (IKS 1.30+ & ROKS 4.15+)

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterDisableOutboundTrafficProtection'
--- PASS: TestAccIBMContainerVPCClusterDisableOutboundTrafficProtection (4640.50s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes	4640.629s

$ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterUpdateDisableOutboundTrafficProtection'
--- PASS: TestAccIBMContainerVPCClusterUpdateDisableOutboundTrafficProtection (3403.31s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes	3403.427s

...

[golibali]

Need to update bluemix-go after PR merged.
IBM-Cloud/bluemix-go#441

[hkantare]

can we add this property to datasource also ?
https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/ibm/service/kubernetes/data_source_ibm_container_vpc_cluster.go

[golibali]

Unfortunately not, because this parameter is not a fetchable one. It can be given at cluster create time, or can be updated after with a seperate API call. If I'm right all the parameters in the resource_ibm_container_vpc_cluster.go are fetchable ones.

[hkantare]

Can you fix the conflicts in above files

[hkantare]

Did we test the current change with existing test cases for version less since we defined the argument as optional and default false ?
can you pls share testcase or add testcase for old kube verisons

[golibali]

Did we test the current change with existing test cases for version less since we defined the argument as optional and default false ? can you pls share testcase or add testcase for old kube verisons

I added a test which tests the existing flag with a non secure-by-default cluster (AKA before 1.30, so 1.29)