-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Cloud Databases):Incorporate new client-error-toolchain in data sources #5320
Conversation
} | ||
|
||
return nil | ||
} | ||
|
||
// DataSourceIBMDatabaseBackupsID returns a reasonable ID for the list. | ||
// dataSourceIBMDatabaseBackupsID returns a reasonable ID for the list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to capitalize this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -8,7 +8,7 @@ require ( | |||
github.com/IBM/apigateway-go-sdk v0.0.0-20210714141226-a5d5d49caaca | |||
github.com/IBM/appconfiguration-go-admin-sdk v0.3.0 | |||
github.com/IBM/appid-management-go-sdk v0.0.0-20210908164609-dd0e0eaf732f | |||
github.com/IBM/cloud-databases-go-sdk v0.6.0 | |||
github.com/IBM/cloud-databases-go-sdk v0.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this sdk version released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are using an outdated way of deal with errors
This PR will:
Community Note
Relates OR Closes #0000
Output from acceptance testing: