Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scc fix: ability to add profile_version during create #5332

Merged
merged 2 commits into from
May 16, 2024

Conversation

tyao117
Copy link
Contributor

@tyao117 tyao117 commented May 3, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #5292

Output from acceptance testing:

$ make testacc TEST=./ibm/service/scc  TESTARGS="-run TestAccIbmSccProfiles*" 
...
=== RUN   TestAccIbmSccProfileAttachmentDataSourceBasic
--- PASS: TestAccIbmSccProfileAttachmentDataSourceBasic (23.46s)
=== RUN   TestAccIbmSccProfileAttachmentDataSourceAllArgs
--- PASS: TestAccIbmSccProfileAttachmentDataSourceAllArgs (21.13s)
=== RUN   TestAccIbmSccProfileDataSourceBasic
--- PASS: TestAccIbmSccProfileDataSourceBasic (17.85s)
=== RUN   TestAccIbmSccProfileDataSourceAllArgs
--- PASS: TestAccIbmSccProfileDataSourceAllArgs (18.08s)
=== RUN   TestAccIbmSccProfilesDataSourceBasic
--- PASS: TestAccIbmSccProfilesDataSourceBasic (14.62s)
=== RUN   TestAccIbmSccProfilesDataSourceAllArgs
--- PASS: TestAccIbmSccProfilesDataSourceAllArgs (13.69s)
=== RUN   TestAccIbmSccProfileAttachmentBasic
--- PASS: TestAccIbmSccProfileAttachmentBasic (18.72s)
=== RUN   TestAccIbmSccProfileAttachmentAllArgs
--- PASS: TestAccIbmSccProfileAttachmentAllArgs (52.87s)
=== RUN   TestAccIbmSccProfileBasic
--- PASS: TestAccIbmSccProfileBasic (24.92s)
=== RUN   TestAccIbmSccProfileAllArgs
--- PASS: TestAccIbmSccProfileAllArgs (27.07s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/scc     233.017s
...

@tyao117 tyao117 marked this pull request as ready for review May 3, 2024 21:56
@tyao117 tyao117 changed the title scc fix: adding scc fix: ability to add profile_version during create May 3, 2024
@ocofaigh
Copy link
Contributor

ocofaigh commented May 7, 2024

@hkantare Is this something you can help get reviewed and merged please? We have been waiting on this fix to address #5292
Thanks

@hkantare hkantare merged commit 7dbe372 into IBM-Cloud:master May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

profile_version parameter in ibm_scc_profile is not working as expected
3 participants