fix(Cloud-Databases): Remove deprecated connectionstrings attribute

[omaraibrahim]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Current we have an issue where connectionstrings are not idempotent as seen below.

  # ibm_database.postgresql will be updated in-place
  ~ resource "ibm_database" "postgresql" {
      + connectionstrings       = (known after apply)
        id                      = "crn:v1:bluemix:public:databases-for-postgresql:us-south:a/40ddc34a953a8c02f10987b59085b60e:1a9d66dd-48dd-4aa3-b7d8-8c9e30d44f63::"
        name                    = "omar-psql-08-07-three"
        tags                    = []
        # (15 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

connectionstrings has been deprecated for 2 years. It is time for it to be removed. After removal idempotency is restored the following happens.

No changes. Your infrastructure matches the configuration.

Output from acceptance testing:

Rabbitmq

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Rabbitmq_Basic'
--- PASS: TestAccIBMDatabaseInstance_Rabbitmq_Basic (1397.28s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1398.940s
...

Mongodb

--- PASS: TestAccIBMDatabaseInstanceMongodbBasic (1615.87s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1617.555s

Elasticsearch Platinum

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Basic'
--- PASS: TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Basic (1788.91s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1790.546s

Redis

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (1203.46s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1205.090s

[lornakelly]

@omaraibrahim Can you update the PR with a description and output from running tests. I know its resource but still needs to be done on every PR from what I can tell

[lornakelly]

LGTM