Spelling #299
Merged
Spelling #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Feb 1, 2024
| @@ -770,6 +770,15 @@ <h3> <a id="current-limitations" class="anchor" href="#current-limitations" aria | |||
| <li>$parseInteger()</li> | |||
| </ul> | |||
| <p>We did not implement any of <a href="https://docs.jsonata.org/embedding-extending" rel="nofollow">https://docs.jsonata.org/embedding-extending</a></p> | |||
| <p>From: <a href="https://docs.jsonata.org/date-time" rel="nofollow">https://docs.jsonata.org/date-time</a> $fromMillis() only accepts a number, not the format picture, nor timezone $now() does not accept the picture string (e.g., $now("[Y0000]") reports an arg1 error</p> | |||
There was a problem hiding this comment.
This was more or less incomprehensible
Comment on lines
-130
to
-134
| Boolean: unchanged string: empty false string: non-empty true number: 0 false | ||
| number: non-zero true null: false array: empty false array: contains a member | ||
| that casts to true true array: all members cast to false false object: empty | ||
| false object: non-empty true function: (functions are not currently | ||
| supported) false</div> |
There was a problem hiding this comment.
this absolutely was incomprehensible
Comment on lines
-206
to
-207
| The convertJsonNodeToBoolean method converts the node passed in to a boolean | ||
| based on the casting semnatics defined by JSONata. |
There was a problem hiding this comment.
i'm not quite sure where this should go. Since it sorta fell in the middle of a block i'm consistently replacing... I kicked it below, but i'm not wed to that.
| // "\$" followed any character besides '<' and and digit into $ + this character | ||
| // "\$" followed any character besides '<' and a digit into $ + this character |
| * Java behaves differently to the Javascript String::split | ||
| * Java behaves differently to the JavaScript String::split |
| JsonNode intface = mapper.readTree("{\"a\":2}"); | ||
| JsonNode intFace = mapper.readTree("{\"a\":2}"); |
There was a problem hiding this comment.
I couldn't tell if this was an intentional misspelling of interface. I personally prefer interface_ or iface in that case. I'm assuming that it isn't here...
|
@jsoref this was very kind of you to fix all these issues. Thank you. I'll release a new version incorporating these changes today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/JSONata4Java/actions/runs/7736523304#summary-21094019493
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/JSONata4Java/actions/runs/7736523547#summary-21094019850