Allow building windows wheel from CI #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#12
Description
Add a new job to the wheels stage that uses
cibuildwheelto create Windows wheels:torch+cpufrom the torch wheel repo. It seems the torch Windows wheels are not uploaded to pypi systematically, and some errors were encountered using the ones that were available (1.7.0).FindTorch.cmake)Please note this is still experimental, and no Windows wheels will be published yet.
Details
The wheel do not included the
.dlldependencies, ascibuildwheeldoes not "repair" the wheels in the same way as Linux/OSX. This will be fixed in future iterations - in the meantime, the building of wheels have been left opt-in with a different branch name (release/win-instead of justrelease/).More information: pypa/cibuildwheel#459