Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db2mlops #45

Merged
merged 6 commits into from
Mar 28, 2022
Merged

Db2mlops #45

merged 6 commits into from
Mar 28, 2022

Conversation

pwharned
Copy link
Contributor

I found a procedure for managing and storing models in DB2 that I thought would be useful.

  1. We register a single python UDTF that also takes a b64 encoded string as an additional parameter
  2. Store the model as a b64 encoded string in a table in the database
  3. Model is passed into the UDTF at runtime

Provides a regular SQL interface for doing CRUD with new models and storing them in the database.

Improvement suggestions welcome - I'm not sure what is the best datatype for a variable length chararray/string in the UDTF...

@pwharned pwharned requested a review from kdrodger as a code owner March 23, 2022 21:06
Copy link
Member

@kdrodger kdrodger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Patrick. Just a couple of relatively minor comments.

@pwharned pwharned requested a review from kdrodger March 25, 2022 15:18
@pwharned
Copy link
Contributor Author

My understanding is that joblib is faster than pickle particularly with numpy arrays - not sure how significant that is.

@kdrodger
Copy link
Member

kdrodger commented Mar 25, 2022

My understanding is that joblib is faster than pickle particularly with numpy arrays - not sure how significant that is.

I think I've seen that in some cases as well, and agreed, not sure that it really matters in practice. The only thing I'd maybe consider is documenting in the comments if there's a reason why a specific choice like that is made. Thanks.

@kdrodger kdrodger merged commit 92cbb0e into IBM:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants