Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db2 for Machine Learning Samples #6

Merged
merged 7 commits into from
Aug 8, 2019
Merged

Db2 for Machine Learning Samples #6

merged 7 commits into from
Aug 8, 2019

Conversation

rohithravin
Copy link
Contributor

Hi!

I'm an intern under Vin. This pull request is for the new Db2 code samples for machine learning. Each notebook is to show how Db2 can interact as a data source with different machine learning libraries (Tensorflow, H2o, and Sklearn).

I believe Vin has talked with you guys before to add code samples for db2 with machine learning. He also talked to Kelly Rodger as well.

If you have any questions, you can contact me on IBM Slack or by emailing me at [email protected]

Copy link
Member

@kdrodger kdrodger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just one question and one minor change is needed @rohithravin . The .DS_Store file (MacOS attributes) should not be integrated with the PR. Please remove it, thanks.


In these three notebooks, we will be demonstrating how programmers can use Db2 as a data source when creating machine learning models with huge data sets. Each notebook talks about how Db2 can be used with a specific popular machine learning libarary- `sklearn`, `h2o`, and `tensorflow`.

Before you start using these notebooks, make sure you have created a Db2 On Cloud instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if I already have Db2 somewhere else - can these samples be used outside of a Db2 on Cloud instance? Should we also provide guidance for scenarios where an instance may already exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just updated it!

@kdrodger kdrodger merged commit 5cf6ce5 into IBM:master Aug 8, 2019
@junsulee75
Copy link
Member

junsulee75 commented Jan 6, 2021

@rohithravin

For the example, I suspect there is a minor issue to fix.
db2-samples/db2_for_machine_learning_samples/notebooks/Db2 Sample For Tensorflow.ipynb

As we imported padas libary as the name pd

import pandas as pd
..

The following line will throw errors. ( At least, from my test on Watson studio which is internally Python 3.6 miniconda env. )

wine = pandas.read_sql(sql,hdbi)

I think this should be like below.

wine = pd.read_sql(sql,hdbi)

For your review and revision.
Thank you,
Jun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants