fix: added support for winrm_password for windows custom images #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ujjwal Kumar <[email protected]>
astha-jain
reviewed
Aug 16, 2024
README.md
Outdated
| @@ -225,6 +225,7 @@ ssh_port | int | Optional | The port that SSH will be available on. Defaults to | |||
| ssh_timeout | string | Optional | The time to wait for SSH to become available before timing out. The format of this value is a duration such as "5s" or "5m". | |||
| ***Windows Communicator Variables*** | | |||
| winrm_username | string | Optional | The username to use to connect to WinRM. | |||
| winrm_login_password | string | Optional | The password to use to connect to WinRM. (For custom windows images) | |||
There was a problem hiding this comment.
I would recommend winrm_password keyword in parity with existing winrm_username
builder/ibmcloud/vpc/config.go
Outdated
| @@ -45,6 +45,8 @@ type Config struct { | |||
| VSIUserDataFile string `mapstructure:"vsi_user_data_file"` | |||
| VSIUserDataString string `mapstructure:"vsi_user_data"` | |||
|
|
|||
| WinRMLoginPassword string `mapstructure:"winrm_login_password"` | |||
|
|
|||
tested. lgtm |
uibm
changed the title
astha-jain
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.