Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use specific trust server #35

Merged
merged 1 commit into from
Sep 30, 2018

Conversation

jw-s
Copy link
Contributor

@jw-s jw-s commented Sep 23, 2018

Describes how a user can use a different trust server for a repository.

@jw-s
Copy link
Contributor Author

jw-s commented Sep 23, 2018

@liamawhite I obviously don't have access to the IBM internal docs so I can't change that. Do you want to keep the image policy example in the readme?

Copy link
Member

@molepigeon molepigeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! I've got a couple of comments, mostly to try to keep the style consistent throughout the doc.

@molepigeon
Copy link
Member

molepigeon commented Sep 24, 2018

I obviously don't have access to the IBM internal docs so I can't change that. Do you want to keep the image policy example in the readme?

I'm happy with having an example policy in the README. We don't document the available configuration options, though, so we'll need to either do that or link out to the IBM Cloud docs.

FYI, you can actually submit edits to the IBM Cloud docs through Github - there's an "Edit in Github" link at the top of each topic. The security enforcement ones are here: https://github.com/IBM-Bluemix-Docs/Registry/blob/master/registry_security_enforce.md.

That said, we manage the rollout of the IBM built Container Image Security Enforcement tool separately from Portieris, since it's shipped as a built chart in a repo rather than installed from Github. If you do open a PR against the docs repo, please could you @ me in it so that I can coordinate with our doc writers and make sure the docs accurately reflect what's available in our chart?

@jw-s jw-s force-pushed the custom-trust-server-documentation branch from 4b70db9 to 513d7ea Compare September 25, 2018 11:40
@liamawhite liamawhite merged commit 8312bae into IBM:master Sep 30, 2018
tim-gp pushed a commit to tim-gp/portieris that referenced this pull request Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants