Rewrite image tests to not use ginkgo #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and actually make them run
molepigeon
commented
Oct 11, 2018
helpers/image/image_test.go
Outdated
| ContentTrustErr: false, | ||
| // TODO the previous ginkgo test was testing for port 443, but the code returns 4443. Need to verify which is correct. | ||
| // ContentTrustURL: "https://quay.io:443", | ||
| ContentTrustURL: "https://quay.io:4443", |
There was a problem hiding this comment.
I'm not sure which URL is correct for Quay's notary server. https://quay.io:4443 gives connection refused, and https://quay.io:443 is the same as the registry URL.
The old test said port 443 (although the test never ran), and the code returns 4443.
@ecordell @ericavonb please could one of you confirm which port is the one that we should be using for notary information about images from Quay?
There was a problem hiding this comment.
Quay.io is configured similarly to dockerhub, so the trust url is on the same url as the registry.
molepigeon
force-pushed
the
imagetests
branch
from
2ab331e to
ae13bd1
Compare
liamawhite
approved these changes
Oct 11, 2018
tim-gp
pushed a commit
to tim-gp/portieris
that referenced
this pull request
Oct 1, 2020
* Rewrite image tests to not use ginkgo ... and actually make them run * Correct quay.io port to 443 * Update golint location to use golang.org link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and actually make them run!