Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples #1304

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Examples #1304

merged 3 commits into from
Mar 15, 2019

Conversation

jeroenrinzema
Copy link
Contributor

As discussed in #1099. This PR adds a simple consumer group example as a sort of cheat sheet for developers already working with Sarama or new developers interested in using Sarama.

More examples could be created for for example the Kafka Sarama admin client. Please tell me if someone is interested in more examples, I could include them into this PR.

@ghost ghost added the cla-needed label Mar 8, 2019
@ghost ghost removed the cla-needed label Mar 8, 2019
@bai
Copy link
Contributor

bai commented Mar 12, 2019

Thanks for this!

There seem to be a valid errcheck failure on CI:

errcheck -ignorepkg fmt github.com/Shopify/sarama/...
examples/consumergroup/main.go:83:19:	go client.Consume(ctx, strings.Split(topics, ","), &consumer)
examples/consumergroup/main.go:93:14:	client.Close()
make: *** [errcheck] Error 1
travis_time:end:089e1ade:start=1552059645250063283,finish=1552059649462728896,duration=4212665613
�[0K�[31;1mThe command "make errcheck" exited with 2.�[0m

@varun06 varun06 merged commit b2a5c49 into IBM:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants