Update API Keys per latest version of the spec #74
Conversation
The spec page on the wiki was updated with new key values on March 19: https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol
|
Any idea why this changed, and nothing else?? |
|
Nope, but the guy who changed it is a core Kafka committer, not some random. |
|
Do you know what version started using the new API keys? 0.8.1? |
|
Based on the timing I guess that this is a post-0.8.1 change (targetting 0.9.0?) but I've not been following closely; I only noticed this because I'm subscribed to changes on the wiki page. I don't know if 0.8.1 even implements those APIs yet (0.8.0 didn't) so they may just be making a clean break now that they actually plan on using them for something? |
|
Anyways, you're welcome to postpone merging this until we can clarify. |
|
I am fine merging this if this is not used yet in released version - it's just a curious change. |
|
These keys are not for post-0.8.1, as far as I can see they are actually used in 0.8.1 and current trunk. Looks like keys 6 and 7 were actually used for UpdateMetadataRequest and ControlledShutdownRequest respectively, but the wiki page doesn't document these, unfortunately. |
|
Is there non-code documentation for any of that, or does somebody need to email kafka-dev and complain that the wiki is stale? |
|
I don't know, I'm just starting to use kafka and don't know what's where yet (besides, reading code is somewhat easier for me, turns out to be more authoritative too). Probably a good idea to complain. |
|
Closing this as #77 has been merged. |
The spec page on the wiki was updated with new key values on March 19:
https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol
@wvanbergen