Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile for samples need to work in both product and open-source #91

Closed
chanskw opened this issue Feb 12, 2015 · 2 comments
Closed

Makefile for samples need to work in both product and open-source #91

chanskw opened this issue Feb 12, 2015 · 2 comments

Comments

@chanskw
Copy link
Collaborator

chanskw commented Feb 12, 2015

Problem reported from Inet, but still valid here:

The Makefiles in $STREAMS_INSTALL/samples/com.ibm.streamsx.inet/HTTPStreamRead as well as the InetSource and InetSourceDynamicURL samples all use this definition to specify the location of the toolkit:

STREAMS_INET_TOOLKIT ?=../../com.ibm.streamsx.inet

However, the relative path to the toolkit from those directories is actually this:
../../../toolkits/com.ibm.streamsx.inet

So, "make" fails with the toolkit not being found.

toolkit path should be set to:
STREAMS_INET_TOOLKIT ?=../../com.ibm.streamsx.inet:${STREAMS_INSTALL}/toolkits/com.ibm.streamsx.inet

conglisc added a commit to conglisc/streamsx.messaging that referenced this issue Mar 4, 2015
@chanskw
Copy link
Collaborator Author

chanskw commented Apr 22, 2015

Is this one really fixed? I did not see Makefile changes.
Please also look at the repository and make sure all the changes are in.

@chanskw
Copy link
Collaborator Author

chanskw commented Apr 22, 2015

Nevermind.. found them...
But please review changes nevertheless.

@chanskw chanskw closed this as completed Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant