Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(engine): fix circular structure caused by aria-owns #2164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(engine): fix circular structure caused by aria-owns #2164

wants to merge 1 commit into from

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 24, 2025 •
edited
Loading

  • Other (Provide information): engine bug related to aria-own

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@shunguoy shunguoy requested a review from tombrunet January 24, 2025 14:37
@shunguoy shunguoy marked this pull request as ready for review January 24, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombrunet tombrunet tombrunet approved these changes

Assignees

@tombrunet tombrunet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stackoverflow in getNodeHierarchy
2 participants
@shunguoy @tombrunet