-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrule(meta_refresh_delay | meta_redirect_optional) Fix the rules to align with ACT V4 #2168
Conversation
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together. Updates `path-to-regexp` from 0.1.10 to 0.1.12 - [Release notes](https://github.com/pillarjs/path-to-regexp/releases) - [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md) - [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12) Updates `express` from 4.21.0 to 4.21.2 - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md) - [Commits](expressjs/express@4.21.0...4.21.2) --- updated-dependencies: - dependency-name: path-to-regexp dependency-type: indirect - dependency-name: express dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tom Brunet <[email protected]>
* reset filter fix * css fix --------- Co-authored-by: Tom Brunet <[email protected]>
…TML report page (#2140) * truncating url * remove unused import * Adjust tooltip location --------- Co-authored-by: Tom Brunet <[email protected]>
#1842 (#2137) * carbon package update and use new carbon combobutton * alignment fix --------- Co-authored-by: Tom Brunet <[email protected]>
…redo merge to v4 dev
Sync dev-2091-redo with dev-2091-redo-v4
Checking the Artifacts for the correct ACT mapping |
Tested fine in Chrome and Firefox |
Testing AltoroMutual in Chrome found not issue. Following procedures in Updating, building, and testing Checker Rules & Help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed testing in Chrome and Firefox
This PR is related to the following issue(s):
meta_refresh_delay
|meta_redirect_optional
) Reports "cannot tell" and "passed" while ACT bisz58 expects "Failed" for 3 Fail Example test cases #2091element_orientation_unlocked
) Reports "inapplicable" while ACT b33eff expects "Failed" #2092Testing reference:
I have conducted the following for this PR:
Assets to aide review attached
Definition of Done