Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(meta_refresh_delay | meta_redirect_optional) Fix the rules to align with ACT V4 #2168

Merged
merged 9 commits into from
Feb 4, 2025

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jan 24, 2025

  • Rule bug: meta_refresh_delay | meta_redirect_optional

This PR is related to the following issue(s):

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

Assets to aide review attached

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

dependabot bot and others added 9 commits December 16, 2024 09:34
Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>
* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>
…TML report page (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>
#1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>
Sync dev-2091-redo with dev-2091-redo-v4
@philljenkins
Copy link
Contributor

Checking the Artifacts for the correct ACT mapping

@philljenkins
Copy link
Contributor

Tested fine in Chrome and Firefox

@philljenkins
Copy link
Contributor

philljenkins commented Jan 29, 2025

Testing AltoroMutual in Chrome found not issue.
Testing AltoroMutual in Firefox found no issues.

Following procedures in Updating, building, and testing Checker Rules & Help

Screenshot of Checker in Firefox:
Screenshot 2025-01-29 at 5 23 18 PM

Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed testing in Chrome and Firefox

@tombrunet tombrunet merged commit a5559ab into main-4.x Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment