Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New filters on SurgeAlerts #1976

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

szabozoltan69
Copy link
Contributor

Refers to #1975

@szabozoltan69 szabozoltan69 force-pushed the feature/filters-of-surge-alerts branch 3 times, most recently from 2738c63 to bc10c81 Compare December 11, 2023 10:14
@szabozoltan69 szabozoltan69 marked this pull request as ready for review December 11, 2023 10:15
@szabozoltan69 szabozoltan69 changed the title W-I-P New filters on SurgeAlerts Dec 11, 2023
@szabozoltan69 szabozoltan69 force-pushed the feature/filters-of-surge-alerts branch from bc10c81 to 2eb6b6c Compare December 11, 2023 16:12
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few suggestions

notifications/drf_views.py Outdated Show resolved Hide resolved
notifications/tests.py Outdated Show resolved Hide resolved
notifications/tests.py Outdated Show resolved Hide resolved
@thenav56 thenav56 force-pushed the feature/filters-of-surge-alerts branch from bcc376e to 270e48a Compare December 12, 2023 08:42
- Replace filter methods
- Define Factories for MolnixTag
- Add django-stubs for django type support
@thenav56 thenav56 force-pushed the feature/filters-of-surge-alerts branch from 270e48a to 79b4dba Compare December 12, 2023 08:54
@szabozoltan69 szabozoltan69 merged commit 820e722 into develop Dec 12, 2023
@szabozoltan69 szabozoltan69 deleted the feature/filters-of-surge-alerts branch December 12, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants