Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and push docker images and helm charts on every push to develop #2086

Conversation

sunu
Copy link
Collaborator

@sunu sunu commented Mar 29, 2024

The CI will build appropriately tagged docker images and helm charts for every push to develop and for every tag. We will used these published images and charts to deploy go-api once we move deployment to a separate repo.

The docker images and Helm charts are published to GHCR.

refs #1885

cc @batpad @szabozoltan69

We will used these published images and charts to deploy go-api once we move deployment to a separate repo

refs IFRCGo#1885
@sunu sunu marked this pull request as draft March 29, 2024 10:53
@sunu sunu marked this pull request as ready for review March 29, 2024 11:24
@szabozoltan69
Copy link
Contributor

@sunu @batpad Recently all our GO infrastructure is in Azure, including the ifrcgoacr container registry.
Why don't we use this container registry instead of introducing a new one? We can have multiple repos in it.

@sunu
Copy link
Collaborator Author

sunu commented Mar 29, 2024

@szabozoltan69 We can keep using Azure container registry if you like. But I think the Github registry provides two slight advantages in terms of developer experience:

  1. It provides better visibility - the published docker images and helm charts listing will be visible right next to the code in the repo like this:
image
  1. When we roll out the playground cluster for folks to try out and deploy their apps, we also want them to be able to publish their own Docker images and Helm charts. Instead of using the ifrcgoacr registry, which would mean we have to give out login details or take on the job of building the images ourselves, it would be better if everyone could do this on their own. By using the GitHub registry for the go-api, we set a consistent example for how other apps in the go ecosystem should do things too.

@szabozoltan69
Copy link
Contributor

Ok, @sunu – I can accept this for playground (or try-it-out) purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants