Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNI Per Capita for WB #2135

Merged
merged 2 commits into from
May 13, 2024
Merged

Add GNI Per Capita for WB #2135

merged 2 commits into from
May 13, 2024

Conversation

k9845
Copy link
Contributor

@k9845 k9845 commented May 8, 2024

Addresses

Changes

  • Added world_bank_gni_capita to fetch GNI/Capita from World Bank

Checklist

docker-compose exec serve bash ./manage.py ingest_worldbank
  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

@k9845 k9845 requested review from samshara and thenav56 and removed request for samshara May 8, 2024 05:48
@k9845 k9845 force-pushed the feature/wb-gni-capita branch from 42ddea5 to 7471e18 Compare May 8, 2024 07:55
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's add trailing commas
https://antimonit.github.io/2022/01/25/trailing_commas.html

@samshara samshara requested a review from thenav56 May 9, 2024 09:37
@samshara samshara merged commit 1f9555c into develop May 13, 2024
1 check passed
@k9845 k9845 deleted the feature/wb-gni-capita branch May 13, 2024 09:59
@k9845
Copy link
Contributor Author

k9845 commented May 13, 2024

@szabozoltan69 Can you also run the following command?
docker-compose exec serve bash ./manage.py ingest_worldbank

@szabozoltan69
Copy link
Contributor

Deployed, ingest_worldbank is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants