Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to remove subcomponent of component14 #2372

Merged
merged 10 commits into from
Jan 15, 2025
Merged

Add logic to remove subcomponent of component14 #2372

merged 10 commits into from
Jan 15, 2025

Conversation

sudip-khanal
Copy link
Contributor

@sudip-khanal sudip-khanal commented Jan 5, 2025 •
edited by susilnem
Loading

Addresses

Changes

  • Add migration to migrate sub-component of component 14 to component 14
  • Remove sub-component of component 14 form admin and filter

Checklist

Things that should succeed before merging.

  • Updated/ran unit tests
  • Updated CHANGELOG.md

Release

If there is a version update, make sure to tag the repository with the latest version.

susilnem
susilnem requested changes Jan 6, 2025
View reviewed changes
Copy link
Member

@susilnem susilnem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes...
Let's just use a script instead of a migration file here.

per/admin.py Outdated Show resolved Hide resolved
per/drf_views.py Outdated Show resolved Hide resolved
per/migrations/0124_migrate_sub_component_to_component14.py Outdated Show resolved Hide resolved
per/migrations/0124_migrate_sub_component_to_component14.py Outdated Show resolved Hide resolved
per/migrations/0124_migrate_sub_component_to_component14.py Outdated Show resolved Hide resolved
@susilnem susilnem force-pushed the project/operational-learning2.0 branch from e1ee468 to c54ef91 Compare January 7, 2025 08:27
@susilnem susilnem force-pushed the feature/ops-learning-enhancement branch from 629fd28 to 6154cb2 Compare January 7, 2025 08:31
@susilnem susilnem marked this pull request as ready for review January 8, 2025 04:07
@samshara samshara mentioned this pull request Jan 10, 2025
Merged
6 tasks
thenav56
thenav56 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@thenav56 thenav56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some noise data in the test case.

Let's QA using alpha instances

@susilnem susilnem merged commit 059b5ff into project/operational-learning2.0 Jan 15, 2025
3 checks passed
@susilnem susilnem deleted the feature/ops-learning-enhancement branch January 15, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susilnem susilnem susilnem requested changes

@thenav56 thenav56 thenav56 approved these changes

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi approved these changes

@sudan45 sudan45 Awaiting requested review from sudan45

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudip-khanal @thenav56 @Rup-Narayan-Rajbanshi @susilnem