Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project: SSO #2387

Merged
merged 9 commits into from
Feb 3, 2025
Merged

Project: SSO #2387

merged 9 commits into from
Feb 3, 2025

Conversation

thenav56
Copy link
Member

@thenav56 thenav56 commented Jan 17, 2025 •
edited
Loading

Addresses

Changes

  • Add django-oauth-toolkit
  • Add config for OIDC
  • Add documentation
  • Add login/logout page within go-api

🚨 🚨 Deployment checklist 🚨 🚨

  • Generate RSA keys for OIDC and store in Azure pipeline
  • Update go-deploy config with new keys
OIDC_ENABLE=true
OIDC_RSA_PRIVATE_KEY_BASE64_ENCODED=YOUR-ENCODED-VALUE
OIDC_RSA_PUBLIC_KEY_BASE64_ENCODED=YOUR-ENCODED-VALUE

Detail here:

NOTE: Can't use the existing JWT token due to different algorithm used

thenav56 and others added 8 commits January 16, 2025 17:19
@thenav56
Fix logging issue
9783964 
- Fix encoding issue with JWT tokens
- Disable package mode in pyproject.toml
@thenav56
Install django-oauth-toolkit
63d51a7
@thenav56
Add Oauth openid configurations
e6e5c85
@tnagorra @thenav56
Add login form page and logout page
82408f7 
- Style login page and authorize page
- Style base page for django-allauth
@thenav56
Add config to disable OIDC
bd59e21 
- pre-commit fixes
- Move login.html -> oauth2_provider/sso-auth.html
- Add OIDC config check using django check
- Use new sso-auth for default LOGIN/LOGOUT redirect
@thenav56
Add docs for using SSO (local development)
7feb733
@thenav56
Add cleartokens cronjob to clear expired tokens
0e829a7
@thenav56
Feature/sso helm (#2386)
5418fe6 
* Update helm config to support OIDC configs
* Fix redirection issue on OIDC disabled mode
@szabozoltan69
Copy link
Contributor

Heroic job. Congratulations!

@thenav56 thenav56 marked this pull request as ready for review January 28, 2025 12:01
@thenav56
Copy link
Member Author

Hey @szabozoltan69 Please review when you have time

@thenav56 thenav56 mentioned this pull request Feb 3, 2025
Merged
@thenav56
Copy link
Member Author

thenav56 commented Feb 3, 2025

Hey @szabozoltan69 I have updated go-deploy pipeline for the config.
When you have time could you merge this branch and https://github.com/IFRCGo/go-deploy/pull/47/files to deploy SSO to staging.

NOTE: Users can't login in SDT without go-api SSO.

@szabozoltan69 szabozoltan69 merged commit 327e61a into develop Feb 3, 2025
7 checks passed
@szabozoltan69 szabozoltan69 deleted the project/sso branch February 3, 2025 05:45
@szabozoltan69
Copy link
Contributor

Hey @thenav56 – deployed to Staging with the merged go-deploy.
ENV-vars are in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabozoltan69 szabozoltan69 szabozoltan69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thenav56 @szabozoltan69 @tnagorra