Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Unit Design Audit Fixes #1333

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Local Unit Design Audit Fixes #1333

merged 3 commits into from
Sep 5, 2024

Conversation

shreeyash07
Copy link
Collaborator

@shreeyash07 shreeyash07 commented Aug 28, 2024 •
edited by samshara
Loading

Addresses:

Changes

  • Remove ellipsize heading from map pop up
  • Add local unit form modal in local unit map
  • change color of validate button

This PR doesn't introduce:

  • typos
  • conflict markers
  • unwanted comments
  • temporary files, auto-generated files or secret keys
  • console.log meant for debugging
  • codegen errors

@shreeyash07 shreeyash07 requested a review from samshara August 28, 2024 04:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4192da1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
go-web-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shreeyash07 shreeyash07 marked this pull request as ready for review August 30, 2024 05:48
@shreeyash07 shreeyash07 force-pushed the fix/local-unit-pop-up-heading branch from a85fa31 to 446c620 Compare August 30, 2024 05:48
@shreeyash07 shreeyash07 force-pushed the fix/local-unit-pop-up-heading branch from 446c620 to 5b253fd Compare September 2, 2024 11:02
@samshara samshara force-pushed the fix/local-unit-pop-up-heading branch from 5b253fd to 1c27bc1 Compare September 4, 2024 08:27
@samshara samshara force-pushed the fix/local-unit-pop-up-heading branch from 1c27bc1 to 451c48a Compare September 5, 2024 06:23
@samshara samshara force-pushed the fix/local-unit-pop-up-heading branch from 451c48a to 4192da1 Compare September 5, 2024 06:42
@samshara samshara changed the title Local Unit Small Fixes Local Unit Design Audit Fixes Sep 5, 2024
@samshara samshara merged commit 8cd10b2 into develop Sep 5, 2024
9 checks passed
@samshara samshara deleted the fix/local-unit-pop-up-heading branch September 5, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samshara samshara samshara approved these changes

@barshathakuri barshathakuri barshathakuri approved these changes

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

Assignees

@samshara samshara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shreeyash07 @samshara @barshathakuri