project: Operational learning 2.0 #1629
Conversation
🦋 Changeset detectedLatest commit: 4843cb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
frozenhelium
force-pushed
the
project/operational-learning-2.0
branch
from
92f7f35 to
b9a1d6a
Compare
- include the `endDate` if it matches the exact start of a year
| const LEARNING_COUNT_LOW_COLOR = '#AEB7C2'; | ||
| const LEARNING_COUNT_HIGH_COLOR = '#011E41'; |
There was a problem hiding this comment.
Do we have these colors on the design? Can we use var(--go-ui-color-<some-color>) here?
app/src/views/OperationalLearning/Stats/OperationalLearningMap/index.tsx
Outdated
Show resolved
Hide resolved
| <NumberOutput | ||
| value={0} | ||
| /> |
There was a problem hiding this comment.
Any reason this is set as zero?
There was a problem hiding this comment.
it's the value for the lowest learning count. Defined a constant and used instead.
| const groupedData: Record<string, Record<SourceType, number>> = {}; | ||
|
|
||
| data.forEach((entry) => { | ||
| const year = getFormattedDateKey(entry.date); |
|
|
||
| const strings = useTranslation(i18n); | ||
| const alert = useAlert(); | ||
| const [activePointKey, setActivePointKey] = useState<string>(); |
There was a problem hiding this comment.
Is this type correct? The state is not defined here.
There was a problem hiding this comment.
Yes the type here is correct.
| const oldestDate = new Date(Math.min(...dates.map((date) => date.getTime()))); | ||
| const latestDate = new Date(Math.max(...dates.map((date) => date.getTime()))); |
There was a problem hiding this comment.
We should also check for length of dates
| if (isDefined(value) && value > 0) { | ||
| return value; | ||
| } | ||
| return undefined; |
There was a problem hiding this comment.
We can use ternary operator here.
| strings.sourceOthers, | ||
| ]); | ||
|
|
||
| const activePointData = activePointKey ? sourcesOverTimeData?.[activePointKey] : undefined; |
- Added translation migrations - Created changesets
frozenhelium
dismissed
tnagorra’s stale review
Requested changes implemented!
Summary
Addresses
Depends On
This PR Ensures:
console.logstatements meant for debugging