RAP-121 Address sonar feedback

IHTSDO · Jan 10, 2025 · 972c4f1 · 972c4f1
1 parent f75c875
commit 972c4f1
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 8 deletions.
diff --git a/...a/org/ihtsdo/buildcloud/core/service/build/compare/type/PostConditionCheckComparison.java b/...a/org/ihtsdo/buildcloud/core/service/build/compare/type/PostConditionCheckComparison.java
@@ -10,7 +10,6 @@
 import org.ihtsdo.buildcloud.core.service.build.compare.DefaultComponentComparisonReport;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.util.CollectionUtils;
 

diff --git a/...va/org/ihtsdo/buildcloud/core/service/build/compare/type/PreConditionCheckComparison.java b/...va/org/ihtsdo/buildcloud/core/service/build/compare/type/PreConditionCheckComparison.java
@@ -10,7 +10,6 @@
 import org.ihtsdo.buildcloud.core.service.build.compare.DefaultComponentComparisonReport;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.util.CollectionUtils;
 

diff --git a/src/main/java/org/ihtsdo/buildcloud/core/service/build/compare/type/RVFReportComparison.java b/src/main/java/org/ihtsdo/buildcloud/core/service/build/compare/type/RVFReportComparison.java
@@ -26,13 +26,10 @@ public class RVFReportComparison extends ComponentComparison {
 
     public static final String REPORTS = "reports";
 
-    private final String releaseValidationFrameworkUrl;
 
-    public RVFReportComparison() {
-        this.releaseValidationFrameworkUrl = null;
-    }
+    private String releaseValidationFrameworkUrl;
 
-    public RVFReportComparison(String releaseValidationFrameworkUrl) {
+    public RVFReportComparison(@Value("${rvf.url}") String releaseValidationFrameworkUrl) {
         this.releaseValidationFrameworkUrl = releaseValidationFrameworkUrl;
     }
 

diff --git a/.../java/org/ihtsdo/buildcloud/core/service/build/compare/type/ReleasePackageComparison.java b/.../java/org/ihtsdo/buildcloud/core/service/build/compare/type/ReleasePackageComparison.java
@@ -13,7 +13,6 @@
 import org.ihtsdo.otf.rest.exception.ResourceNotFoundException;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Service;
 import org.springframework.util.StreamUtils;