Feat/code review and GitHub flow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feature login added 🍉 * Update README.md * fix:add faker to package.json * fix:add faker to package.json * fix:add faker to package.json * fix:add test user to seed * fix: add envrc to gitignore * fix: delete .envrc * fix src/migrations/20210503202812-create-user.js Co-authored-by: Sebastián Vicencio <[email protected]> * fix src/models/user.js Co-authored-by: Sebastián Vicencio <[email protected]> * fix src/routes/session.js Co-authored-by: Sebastián Vicencio <[email protected]> * fix src/views/layout.html.ejs Co-authored-by: Sebastián Vicencio <[email protected]> * fix src/views/session/new.html.ejs Co-authored-by: Sebastián Vicencio <[email protected]> * fix routes.js * Update src/routes.js Co-authored-by: Sebastián Vicencio <[email protected]> * fix session.js * fix session.js * fix:add faker to package.json Co-authored-by: Kelsey Franken <[email protected]> Co-authored-by: kelseyfranken <[email protected]> Co-authored-by: valeeeriquelme <[email protected]> Co-authored-by: Sebastián Vicencio <[email protected]>
…review Feat/GitHub flow and code review
Dnpoblete
requested changes
May 7, 2021
src/views/books/new.html.ejs
Outdated
| @@ -26,6 +26,14 @@ | |||
| <% }) %> | |||
| </select> | |||
| </div> | |||
| <div> | |||
| <label for="description">Descricionsd</label> | |||
There was a problem hiding this comment.
Diego escribiste mal la palabra descripción
There was a problem hiding this comment.
Si, lo arreglare ahora.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Se implemento una funcionalidad que permite mostrar una breve descripción del libro, junto con el número de páginas.
Why?
Dado que no era posible saber de qué se trataba el libro.
How?
Se creo una migración para modificar el recurso libro y se agrego el método en el router de libros.
Testing? (almost required)
No aplica
Screenshots (almost required in frontend)
No aplica
Anything Else? (optional)
No aplica