added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c… #21

dhvasquez · 2021-05-21T20:42:11Z

Bcrypt tutorial

What?

Sequelize hook for hashing with bcrypt
Hash password in seeds with bcrypt hashSync
Hash compare method in user model

Why?

For hashing tutorial video

How?

Use of sequelize hooks to implement hashing using bcrypt library

Testing?

No new route added, so no new test applied

Screenshots

No frontend change

Anything Else?

Functions used

// Hash string
bcrypt.hash(string, SALT_ROUNDS);  // returns Promise that resolves int o a hash
bcrypt.hashSync(string, SALT_ROUNDS);  // synchronous method for hashing

// Hash compare with string
bcrypt.compare(string, hash);  // returns Promise that resolves into bool

Fixed

Added await to compare promise, this change is not reflected in the video, for full change log check this Pull Request.

…ompare

sivicencio

Great and concise code 👍🏼

sivicencio · 2021-05-21T23:52:59Z

src/routes/session.js

@@ -13,7 +13,7 @@ router.post('session.create', '/', async (ctx) => {
  const user = await ctx.orm.user.findOne({ where: { email } });

  /* TODO: replace plain-text password comparison with encrypted version */


Could you remove this line, please? It doesn't apply to this case anymore.

Removed to do comment cause it is already done

added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c…

ee868d5

…ompare

dhvasquez requested a review from sivicencio May 21, 2021 20:42

sivicencio approved these changes May 21, 2021

View reviewed changes

Removed TODO

c2552bd

Removed to do comment cause it is already done

dhvasquez merged commit 350b253 into main May 22, 2021

sivicencio deleted the dhvasquez/feat/hash-example branch July 5, 2021 03:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c… #21

added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c… #21

dhvasquez commented May 21, 2021 •

edited

Loading

sivicencio left a comment

sivicencio May 21, 2021

		@@ -13,7 +13,7 @@ router.post('session.create', '/', async (ctx) => {
		const user = await ctx.orm.user.findOne({ where: { email } });

		/* TODO: replace plain-text password comparison with encrypted version */

added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c… #21

added: sequelize hook for bcrypt, apply bcrypt in seeds, and bcrypt c… #21

Conversation

dhvasquez commented May 21, 2021 • edited Loading

What?

Why?

How?

Testing?

Screenshots

Anything Else?

Functions used

Fixed

sivicencio left a comment

Choose a reason for hiding this comment

sivicencio May 21, 2021

Choose a reason for hiding this comment

dhvasquez commented May 21, 2021 •

edited

Loading