Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in 37f17f3808c1c97bd72c165a530c67a4bfb82edb? #45

Closed
rdoeffinger opened this issue May 6, 2015 · 2 comments
Closed

Typo in 37f17f3808c1c97bd72c165a530c67a4bfb82edb? #45

rdoeffinger opened this issue May 6, 2015 · 2 comments

Comments

@rdoeffinger
Copy link
Contributor

That commit changes
output.replace(QRegExp("\n"), "
");
to
output.replace(QRegExp("\n )"), "
");
was that intentional?
I thought the point was to replace all newlines with HTML tags (which I admit I do not know if it is necessary).
The new code triggers only on a sequence I'd think would almost never appear in the output...
@annejan
Copy link
Member

annejan commented May 6, 2015

You are entirely righ.
Will have a look, probably just a simple typo/paste-o on my part..
It was pretty late last night ;)

annejan added a commit that referenced this issue May 6, 2015
@annejan
Fixed stupid typo / copy-o
6247e58 
#45
@annejan
Copy link
Member

annejan commented May 6, 2015

Fixed in 6247e58

@annejan annejan closed this as completed May 6, 2015
annejan added a commit that referenced this issue Jun 1, 2016
@annejan
Fixed stupid typo / copy-o
19df23c 
#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@annejan @rdoeffinger