Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pwgen and refactor Pass::finished #271

Merged
merged 2 commits into from
Jan 9, 2017
Merged

Fix pwgen and refactor Pass::finished #271

merged 2 commits into from
Jan 9, 2017

Conversation

tezeb
Copy link
Contributor

@tezeb tezeb commented Jan 9, 2017

Fix for #262.
Also "revert' fix for break added in switch. It was unreadable, sorry for that. I hope it's better now.

annejan
annejan approved these changes Jan 9, 2017
View reviewed changes
Copy link
Member

@annejan annejan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better, and it seems my interpretation of the CI notification might have broken the previous iteration.

Thanks for these fixes!

@annejan annejan merged commit 6759fc6 into IJHack:master Jan 9, 2017
@tezeb
Copy link
Contributor Author

tezeb commented Jan 9, 2017

On the bright side you made me update it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annejan annejan annejan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tezeb @annejan