Refactoring #360
Merged
Refactoring #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like this it easier to re-find the content we are interested in.
This can be used to parse the content of the password file in a common place. In a later commit we should replace the parsing in mainwindow and passworddialog.
This also changes the behavior of the main window: If content should be hidden nothing is shown. Else the password is always shown as a field (either with hidden with dots or openly visibly.) the rest is shown as plain text or as field depending on the template settings. This is results in a nicer ui and needs one translation (Password hidden) less.
lukedirtwalker
force-pushed
the
refactoring
branch
from
d653294 to
81f93a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=========================================
+ Coverage 2.92% 6.38% +3.45%
=========================================
Files 36 39 +3
Lines 2698 2695 -3
Branches 361 351 -10
=========================================
+ Hits 79 172 +93
+ Misses 2618 2517 -101
- Partials 1 6 +5
Continue to review full report at Codecov.
|
* Split datahelpers.h to userinfo.h and passwordconfiguration.h * Rename passwordConfiguration to PasswordConfiguration * Move some code to separate methods in MainWindow * Handle PasswordConfiguration in QtPassSettings and in ConfigDialog
|
Hi @annejan any chance for a review? Sorry for stressing ;) |
|
I'm sorry I didn't have time earlier . . Hope you have not planted a red-herring I might have missed, but it all looks good to me 👯♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the FileContent class for parsing the password file and use it where we parsed manually before. Also slightly change the behavior of MainWindow how it shows the content (see commit for more details).