Add support for OTP code generation on Linux as requested in #327 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
…gnal finishedOtpShow: ui hang Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
…N and APPLE OTP button and options are hidden. Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
… in imitatePass. Signed-off-by: Ettore Dreucci <[email protected]>
Signed-off-by: Ettore Dreucci <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=========================================
- Coverage 6.5% 6.45% -0.05%
=========================================
Files 39 39
Lines 2553 2571 +18
=========================================
Hits 166 166
- Misses 2387 2405 +18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support for pass-otp extension on Linux as requested in #327.
The configdialog now has an option to activate OTP code generation that happens pressing the button in the menu bar after selecting an entry. If the entry password is an otp url the code is generated, shown in the mainwindow and copied in the clipboard, otherwise an error is shown.
On windows and apple the option in the configdialog is hidden as well as the button.
In imitatepass the OtpGenerate method is currently empty.
I've already writted an otp library but for now I do not know how to integrate it in imitatePass. Is there a way to get the password of an entry so that I can pass it to the library for the otp code generation?