Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-automatic code cleanup #425

Merged
merged 14 commits into from
Apr 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,16 @@

**Merged pull requests:**

- Use key fingerprint as ID instead of “long” ID. [\#452](https://github.com/IJHack/QtPass/pull/452) ([Natureshadow](https://github.com/Natureshadow))
- Typo: dialouge to dialogue. [\#444](https://github.com/IJHack/QtPass/pull/444) ([georgjaehnig](https://github.com/georgjaehnig))
- Scripts and logic specific to Windows Store releases [\#439](https://github.com/IJHack/QtPass/pull/439) ([rdoeffinger](https://github.com/rdoeffinger))
- For config check, check that the selected binary is available. [\#438](https://github.com/IJHack/QtPass/pull/438) ([rdoeffinger](https://github.com/rdoeffinger))
- Fix character encoding issues for non-UTF-8 locales. [\#435](https://github.com/IJHack/QtPass/pull/435) ([rdoeffinger](https://github.com/rdoeffinger))
- Fixes and improvments for config dialog [\#432](https://github.com/IJHack/QtPass/pull/432) ([rdoeffinger](https://github.com/rdoeffinger))
- Support for using WSL binaries on Windows [\#431](https://github.com/IJHack/QtPass/pull/431) ([rdoeffinger](https://github.com/rdoeffinger))
- Bugfixes and Windows compatibility improvements [\#430](https://github.com/IJHack/QtPass/pull/430) ([mrsch](https://github.com/mrsch))
- Update to prevent the installer requesting admin [\#424](https://github.com/IJHack/QtPass/pull/424) ([hughwilliams94](https://github.com/hughwilliams94))
- Display passwords as QR codes [\#421](https://github.com/IJHack/QtPass/pull/421) ([frawi](https://github.com/frawi))
- Tested working on Mac Os HS with pinentry-mac [\#419](https://github.com/IJHack/QtPass/pull/419) ([riccardocossu](https://github.com/riccardocossu))
- Dutch \(nl\) translation improvements [\#418](https://github.com/IJHack/QtPass/pull/418) ([equaeghe](https://github.com/equaeghe))
- Bugfixes [\#413](https://github.com/IJHack/QtPass/pull/413) ([rdoeffinger](https://github.com/rdoeffinger))
Expand Down
2 changes: 2 additions & 0 deletions FAQ.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ fi
* On some esotheric systems it might be necessary to create a symbolic
link `/usr/bin/pinentry` to your pinentry application of choice
eg: `ln -s /usr/bin/pinentry-qt5 /usr/bin/pinentry`
* On MacOs `pinentry-program /usr/local/bin/pinentry-mac` works after installing `pinentry-mac` from homebrew.


### I have an other issue with gpg

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Windows
At runtime the only real dependency is `gpg2` but to make the most of it, you'll need `git` and `pass` too.

Your GPG has to be set-up with a graphical pinentry when applicable, same goes for git authentication.
On Mac OS X this currently seems to only work with MacGPG2 from gpgtools or pinentry-mac from homebrew.
On Mac OS X this currently seems to only work best with `pinentry-mac` from homebrew, although gpgtools works too.

On most unix systems all you need is:
```
Expand Down
36 changes: 23 additions & 13 deletions localization/localization_ar_MA.ts
Original file line number Diff line number Diff line change
Expand Up @@ -321,12 +321,17 @@ email</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+24"/>
<location line="+25"/>
<source>Pass OTP extension needs to be installed</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+23"/>
<location line="+5"/>
<source>qrencode needs to be installed</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+24"/>
<source>No Clipboard</source>
<translation type="unfinished"></translation>
</message>
Expand All @@ -341,7 +346,7 @@ email</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+418"/>
<location line="+419"/>
<source>No profile selected</source>
<translation type="unfinished"></translation>
</message>
Expand All @@ -351,7 +356,7 @@ email</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+52"/>
<location line="+65"/>
<source>GnuPG not found</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -395,11 +400,16 @@ email</source>
<source>Autodetect</source>
<translation type="unfinished"></translation>
</message>
<message>
<location/>
<source>Use qrencode</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>ImitatePass</name>
<message>
<location filename="../src/imitatepass.cpp" line="+94"/>
<location filename="../src/imitatepass.cpp" line="+95"/>
<location line="+203"/>
<source>Can not edit</source>
<translation type="unfinished"></translation>
Expand Down Expand Up @@ -551,7 +561,7 @@ p, li { white-space: pre-wrap; }
</message>
<message>
<location/>
<location filename="../src/mainwindow.cpp" line="+903"/>
<location filename="../src/mainwindow.cpp" line="+904"/>
<source>Edit</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -655,12 +665,12 @@ p, li { white-space: pre-wrap; }
</message>
<message>
<location line="+4"/>
<location line="+641"/>
<location line="+649"/>
<source>Password</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="-617"/>
<location line="-625"/>
<source>OTP Code</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -804,7 +814,7 @@ p, li { white-space: pre-wrap; }
<context>
<name>QObject</name>
<message>
<location filename="../main/main.cpp" line="+83"/>
<location filename="../main/main.cpp" line="+84"/>
<source>LTR</source>
<translatorcomment>Flips interface</translatorcomment>
<translation>RTL</translation>
Expand All @@ -813,7 +823,7 @@ p, li { white-space: pre-wrap; }
<context>
<name>QtPass</name>
<message>
<location filename="../src/qtpass.cpp" line="+136"/>
<location filename="../src/qtpass.cpp" line="+140"/>
<source>Generating GPG key pair</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -894,7 +904,7 @@ p, li { white-space: pre-wrap; }
<context>
<name>StoreModel</name>
<message>
<location filename="../src/storemodel.cpp" line="+246"/>
<location filename="../src/storemodel.cpp" line="+245"/>
<source>force overwrite?</source>
<translation type="unfinished"></translation>
</message>
Expand Down Expand Up @@ -963,7 +973,7 @@ Red entries are not valid, you will not be able to encrypt to these.</source>
<translation type="unfinished"></translation>
</message>
<message>
<location filename="../src/usersdialog.cpp" line="+24"/>
<location filename="../src/usersdialog.cpp" line="+25"/>
<source>Can not get key list</source>
<translation type="unfinished"></translation>
</message>
Expand All @@ -978,7 +988,7 @@ Red entries are not valid, you will not be able to encrypt to these.</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+94"/>
<location line="+92"/>
<source>created</source>
<translation type="unfinished"></translation>
</message>
Expand Down
36 changes: 23 additions & 13 deletions localization/localization_ca.ts
Original file line number Diff line number Diff line change
Expand Up @@ -327,12 +327,17 @@ email</translation>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+24"/>
<location line="+25"/>
<source>Pass OTP extension needs to be installed</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+23"/>
<location line="+5"/>
<source>qrencode needs to be installed</source>
<translation type="unfinished"></translation>
</message>
<message>
<location line="+24"/>
<source>No Clipboard</source>
<translation>Sense porta-retalls</translation>
</message>
Expand All @@ -347,7 +352,7 @@ email</translation>
<translation>Copia sota demanda al porta-retalls</translation>
</message>
<message>
<location line="+418"/>
<location line="+419"/>
<source>No profile selected</source>
<translation>Cap perfil seleccionat</translation>
</message>
Expand All @@ -357,7 +362,7 @@ email</translation>
<translation>No s&apos;ha seleccionat cap perfil per suprimir</translation>
</message>
<message>
<location line="+52"/>
<location line="+65"/>
<source>GnuPG not found</source>
<translation>No s&apos;ha trobat GnuPG</translation>
</message>
Expand Down Expand Up @@ -401,11 +406,16 @@ email</translation>
<source>Autodetect</source>
<translation type="unfinished"></translation>
</message>
<message>
<location/>
<source>Use qrencode</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>ImitatePass</name>
<message>
<location filename="../src/imitatepass.cpp" line="+94"/>
<location filename="../src/imitatepass.cpp" line="+95"/>
<location line="+203"/>
<source>Can not edit</source>
<translation>No es pot editar</translation>
Expand Down Expand Up @@ -564,7 +574,7 @@ Expire-Date: 0
</message>
<message>
<location/>
<location filename="../src/mainwindow.cpp" line="+903"/>
<location filename="../src/mainwindow.cpp" line="+904"/>
<source>Edit</source>
<translation>Edita</translation>
</message>
Expand Down Expand Up @@ -748,12 +758,12 @@ p, li { white-space: pre-wrap; }
</message>
<message>
<location line="+4"/>
<location line="+641"/>
<location line="+649"/>
<source>Password</source>
<translation>Contrasenya</translation>
</message>
<message>
<location line="-617"/>
<location line="-625"/>
<source>OTP Code</source>
<translation>Codi OTP</translation>
</message>
Expand Down Expand Up @@ -963,15 +973,15 @@ p, li { white-space: pre-wrap; }
<context>
<name>QObject</name>
<message>
<location filename="../main/main.cpp" line="+83"/>
<location filename="../main/main.cpp" line="+84"/>
<source>LTR</source>
<translation>LTR</translation>
</message>
</context>
<context>
<name>QtPass</name>
<message>
<location filename="../src/qtpass.cpp" line="+136"/>
<location filename="../src/qtpass.cpp" line="+140"/>
<source>Generating GPG key pair</source>
<translation type="unfinished">Generació del parell de claus GPG</translation>
</message>
Expand Down Expand Up @@ -1055,7 +1065,7 @@ p, li { white-space: pre-wrap; }
<context>
<name>StoreModel</name>
<message>
<location filename="../src/storemodel.cpp" line="+246"/>
<location filename="../src/storemodel.cpp" line="+245"/>
<source>force overwrite?</source>
<translation>voleu forçar la sobreescriptura?</translation>
</message>
Expand Down Expand Up @@ -1127,7 +1137,7 @@ Les entrades vermelles no són vàlides, no podreu xifrar.</translation>
<translation>Mostra les claus inutilitzables</translation>
</message>
<message>
<location filename="../src/usersdialog.cpp" line="+24"/>
<location filename="../src/usersdialog.cpp" line="+25"/>
<source>Can not get key list</source>
<translation type="unfinished">No es pot obtenir la llista de claus</translation>
</message>
Expand All @@ -1142,7 +1152,7 @@ Les entrades vermelles no són vàlides, no podreu xifrar.</translation>
<translation type="unfinished">No s&apos;ha trobat la clau a l&apos;anell de claus</translation>
</message>
<message>
<location line="+94"/>
<location line="+92"/>
<source>created</source>
<translation>creada</translation>
</message>
Expand Down
Loading