Skip signature with warning #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will help with maintaining changes in the config
Igor-Misic
force-pushed
the
pr-skip_signature_with_warning
branch
from
06c6b22 to
da63d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the solution for #31
It goes in pair with this commit:
IMProject/IMBootloader@1716953
In the previous iteration, we forced singed firmware because there was the possibility of flashing something that is not firmware and then breaking the option to flash anything without connecting JTAG.
Recently we introduced the feature "enter in bootloader with the button" so here we will relax our requirements for flashing unsigned firmware with a warning only.
In case a warning is too much it can be disabled in the
config.jsonwith"enable_signature_warning": "false"Additionally, the config version is added. We will need it in the future to be able to detect if we need to update the config, so the transition to the new/old config can be easier. Logic is still missing.
Regarding IMLedBlink unsigned firmware this
https://github.com/IMProject/IMLedBlink/blob/master/Linker/STM32H7xx.ld#L84-L87
need to be changed to this
https://github.com/IMProject/IMLedBlink/blob/master/Linker/STM32H7xx_SIGNATURE.ld#L90-L95
otherwise flashing will not work properly since the bootloader will get in error.
The current linker script is kept like this because easier for JTAG debugging.
The server has properly built versions, but we will need to see how to build release/debug versions in the future.