better formulation to wrap-up #784
Conversation
There was a problem hiding this comment.
Thanks for the PR @psteinb! Here are a couple of comments. Also, the linter fail in the CI is because it's configured to 80 characters max.
Being said that, reworking this whole notebook has been in my list of to do's for a long time. In particular, we want to use a more realistic dataset, give interpretation to resulting R2 and MSE scores, and mention the actual good practices for modeling, e.g. aligning the test size of TimeSeriesSplit with the forecasting task. In case you want to contribute, feel free to submit a more in depth PR.
| # i.i.d data. It might lead to absurd results. These absurd results can make you | ||
| # think that a predictive model might work while it is not doing so in practice. |
There was a problem hiding this comment.
| # i.i.d data. It might lead to absurd results. These absurd results can make you | |
| # think that a predictive model might work while it is not doing so in practice. | |
| # i.i.d data. It might lead misleading outcomes, creating the false impression | |
| # that a predictive model performs well when it may not be the case in the | |
| # intended real-world scenario. |
| @@ -220,5 +220,5 @@ | |||
| # %% [markdown] | |||
| # In conclusion, it is really important to not use an out of the shelves | |||
There was a problem hiding this comment.
I don't think "out of the shelves" is grammatically correct nor a common term for the students to know. Maybe we can rephrase the whole paragraph.
The last sentence of the
cross_validation_time.ipynbnotebook felt a bit convoluted. I tried my best to improve the formulation.