feature: RoleHandlerHelper#getRoleHandlers(Class), forEachRoleHandler, getParentRoleHandler #1794
Conversation
| } | ||
| } | ||
|
|
||
| public static RoleHandler getParentRoleHandler(CtElement element) { |
There was a problem hiding this comment.
rename to getRoleHandler?
add API documentation?
thanks!
There was a problem hiding this comment.
rename to getRoleHandler?
are you sure? I think that there should be something about parent in the method name, because it returns role of this element in parent.
api doc.
I forgot that ... It compiles without documentation well :-) I will add it
There was a problem hiding this comment.
because it returns role of this element in parent.
a role is always with respect to the parent, right?
There was a problem hiding this comment.
in case of this method yes.
| @@ -71,4 +78,51 @@ public static RoleHandler getOptionalRoleHandler(Class<? extends CtElement> targ | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| /** | |||
| * @param targetClass a Close whose handlers we are looking for | |||
There was a problem hiding this comment.
I don't understand your documentation here: what's a "Close"?
There was a problem hiding this comment.
I should sleep more ... at least sometime ... "Close" is wrong. Correct is "Class" ;-) I will fix it.
|
This PR is OK but for the method name |
|
thanks! |
Some helper methods which allows generically access Spoon model