fix: fully comply with the contract of CtScannerTest#testScannerCallsAllProperties #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,15 +29,15 @@ | |||
| */ | |||
| // autogenerated by CtBiScannerGenerator | |||
| public class CtBiScannerDefault extends spoon.reflect.visitor.CtAbstractBiScanner { | |||
| protected Deque<CtElement> stack = new ArrayDeque<>(); | |||
| protected java.util.Deque<spoon.reflect.declaration.CtElement> stack = new java.util.ArrayDeque<>(); | |||
There was a problem hiding this comment.
Is it correct that current generator produces fully qualified names here?
There was a problem hiding this comment.
yes, the BiScanner generator does not use autoimport
|
Thank You for solving this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all comments are actually scanned. only in references, there is no scan of comments, but this is normal, since references cannot be documented.
fix #1712